N21-1319 ctl showing tool usage #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarvinOehlerkingCap
previously requested changes
Nov 20, 2023
| itemToDelete.value = item; | ||
| isDeleteDialogOpen.value = true; | ||
| await fetchSchoolExternalToolUsage(item.id); | ||
| if (!metadata.value) { |
There was a problem hiding this comment.
not the best way to do it from a user experience standpoint, because when a user makes an action/presses a button, they expect some responding action to happen. If I remember correctly a delay of 500ms between action and response can already cause disorientation. So when the loading takes a second the button press does not feel responsive anymore.
There was a problem hiding this comment.
Will be fixed with other dialog requirements like error handling in the next ticket
src/components/data-external-tool/SchoolExternalApi.composable.unit.ts
Outdated
Show resolved
Hide resolved
src/components/data-external-tool/SchoolExternalToolUsage.composable.unit.ts
Outdated
Show resolved
Hide resolved
src/components/data-external-tool/SchoolExternalToolUsage.composable.unit.ts
Outdated
Show resolved
Hide resolved
src/components/data-external-tool/SchoolExternalToolUsage.composable.unit.ts
Outdated
Show resolved
Hide resolved
1 task
|
Kudos, SonarCloud Quality Gate passed! |
arnegns
approved these changes
Nov 20, 2023
This was referenced Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
This PR handle the display of metadata in ExternalToolSection on the new admin page, when the admin wants to delete a school external tool.
Links to Ticket and related Pull-Requests
https://ticketsystem.dbildungscloud.de/browse/N21-1319
hpi-schul-cloud/schulcloud-server#4543
hpi-schul-cloud/superhero-dashboard#234
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging