Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1319 ctl showing tool usage #4543

Merged
merged 25 commits into from
Nov 20, 2023
Merged

N21-1319 ctl showing tool usage #4543

merged 25 commits into from
Nov 20, 2023

Conversation

mrikallab
Copy link
Contributor

@mrikallab mrikallab commented Nov 10, 2023 •
edited by IgorCapCoder
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-1319
hpi-schul-cloud/superhero-dashboard#234
hpi-schul-cloud/nuxt-client#2922

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@mrikallab mrikallab added the WIP This feature branch is in progress, do not merge into master. label Nov 10, 2023
MarvinOehlerkingCap
MarvinOehlerkingCap requested changes Nov 14, 2023
View reviewed changes
apps/server/src/modules/tool/external-tool/controller/api-test/tool.api.spec.ts Outdated Show resolved Hide resolved
apps/server/src/modules/tool/common/enum/tool-context-type.enum.ts Outdated Show resolved Hide resolved
...er/src/modules/tool/external-tool/controller/dto/response/external-tool-metadata.response.ts Outdated Show resolved Hide resolved
...er/src/modules/tool/external-tool/controller/dto/response/external-tool-metadata.response.ts Outdated Show resolved Hide resolved
apps/server/src/modules/tool/external-tool/controller/api-test/tool.api.spec.ts Outdated Show resolved Hide resolved
apps/server/src/shared/repo/contextexternaltool/context-external-tool.repo.ts Outdated Show resolved Hide resolved
apps/server/src/shared/repo/schoolexternaltool/school-external-tool.repo.ts Outdated Show resolved Hide resolved
apps/server/src/shared/repo/schoolexternaltool/school-external-tool.repo.ts Outdated Show resolved Hide resolved
apps/server/src/modules/tool/external-tool/service/external-tool-metadata.service.ts Outdated Show resolved Hide resolved
apps/server/src/modules/tool/external-tool/service/external-tool-metadata.service.ts Outdated Show resolved Hide resolved
@MBergCap MBergCap mentioned this pull request Nov 15, 2023
Merged
1 task
@mrikallab
N21-1319 review changes
280f3c9
@mrikallab
N21-1319 clean up
44327fd
@mrikallab
N21-1319 clean barrelfile
8a6be9a
@mrikallab
Merge branch 'main' into N21-1319-ctl-showing-tool-usage
ecdb027 
# Conflicts:
#	apps/server/src/modules/tool/external-tool/external-tool.module.ts
#	apps/server/src/modules/tool/school-external-tool/controller/api-test/tool-school.api.spec.ts
#	apps/server/src/modules/tool/school-external-tool/school-external-tool.module.ts
@mrikallab
N21-1319 clean up
6554267
@mrikallab
N21-1319 clean up
c7c8067
@mrikallab
N21-1319 clean up
68869cd
MarvinOehlerkingCap
MarvinOehlerkingCap requested changes Nov 16, 2023
View reviewed changes
apps/server/src/modules/tool/external-tool/controller/api-test/tool.api.spec.ts Outdated Show resolved Hide resolved
...er/src/modules/tool/external-tool/controller/dto/response/external-tool-metadata.response.ts Outdated Show resolved Hide resolved
apps/server/src/modules/tool/external-tool/uc/external-tool.uc.spec.ts Show resolved Hide resolved
apps/server/src/modules/tool/external-tool/uc/external-tool.uc.ts Outdated Show resolved Hide resolved
...erver/src/modules/tool/school-external-tool/service/school-external-tool-metadata.service.ts Outdated Show resolved Hide resolved
apps/server/src/modules/tool/external-tool/service/external-tool-metadata.service.ts Outdated Show resolved Hide resolved
apps/server/src/modules/tool/external-tool/service/external-tool-metadata.service.ts Outdated Show resolved Hide resolved
...erver/src/modules/tool/school-external-tool/service/school-external-tool-metadata.service.ts Outdated Show resolved Hide resolved
...erver/src/modules/tool/school-external-tool/service/school-external-tool-metadata.service.ts Show resolved Hide resolved
@mrikallab mrikallab mentioned this pull request Nov 20, 2023
Merged
3 tasks
@MBergCap MBergCap mentioned this pull request Nov 20, 2023
Merged
1 task
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@IgorCapCoder IgorCapCoder enabled auto-merge (squash) November 20, 2023 15:39
@IgorCapCoder IgorCapCoder removed the WIP This feature branch is in progress, do not merge into master. label Nov 20, 2023
@IgorCapCoder IgorCapCoder merged commit caf63ea into main Nov 20, 2023
46 of 47 checks passed
@IgorCapCoder IgorCapCoder deleted the N21-1319-ctl-showing-tool-usage branch November 20, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvinOehlerkingCap MarvinOehlerkingCap MarvinOehlerkingCap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrikallab @MarvinOehlerkingCap @IgorCapCoder