Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N21-1319 ctl showing tool usage #2922
N21-1319 ctl showing tool usage #2922
Changes from 13 commits
3adc55b
4a2bcb3
dd8cffc
16a4aec
b602a5c
a54c2d7
e0344da
ae7685a
3e78b3f
34de0e3
19e9a9a
f9223cc
cbe4489
1e5eebd
95853f2
6fc0a99
921bd5f
1021de2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not the best way to do it from a user experience standpoint, because when a user makes an action/presses a button, they expect some responding action to happen. If I remember correctly a delay of 500ms between action and response can already cause disorientation. So when the loading takes a second the button press does not feel responsive anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be fixed with other dialog requirements like error handling in the next ticket