#10711: Control loading FontAwesome for vector style

[mahmoudadel54]

Description

This PR handles control the loading of FontAwesome for vector data style.
A boolean cfg called 'loadFontAwesomeForIcons' for Map plugin can be added to control the loading fontAwesome for vector style this will be used for OpenLayers, Leaflet and Cesium. loadFontAwesomeForIcons is with true by default.
This PR enhances the loadFontAwesome function to load only if the vector data has icons.

This is a sample of config Map plugin:

 {
            "name": "Map",
            "cfg": {
              "mapOptions": {
                "openlayers": {
                  "interactions": {
                    "pinchRotate": false,
                    "altShiftDragRotate": false
                  },
                  "attribution": {
                    "container": "#footer-attribution-container"
                  }
                },
                "leaflet": {
                  "attribution": {
                    "container": "#footer-attribution-container"
                  }
                }
              },
              "toolsOptions": {
                "scalebar": {
                  "container" : "#footer-scalebar-container"
                }
              },
              "loadFontAwesomeForIcons": false
            }
          }

Please check if the PR fulfills these requirements

• The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other... Please describe:

Issue

#10711

What is the current behavior?
#10711

What is the new behavior?
If the Map plugin cfg contains loadFontAwesomeForIcons flag with false ---> so it will stop loading fontAwesome for vector data style and if with true -- > fontAwesome will be loaded in adding vector layer to map

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

• Yes, and I documented them in migration notes
• No

Other useful information

[MV88]

please check what i suggest here, also within the project as well

[allyoucanmap]

@MV88 @mahmoudadel54 in another branch I was exporting to loadingFontAwesome to a specific utils (this branch is not merged yet on master)

https://github.com/allyoucanmap/MapStore2/blob/96dea788d349a09fc7512466beae3cd0aebe1fec/web/client/utils/FontUtils.js

wouldn't it be better to expose a register function instead to have a loadFontAwesomeForIcons config?

let fontAwesomeLoaded = false;

export const isFontAwesomeReady = () => fontAwesomeLoaded;

let defaultLoadFontAwesome = () => {
    if (fontAwesomeLoaded) {
        return Promise.resolve();
    }
    // async load of font awesome
    return import('font-awesome/css/font-awesome.min.css')
        .then(() => {
            // ensure the font is loaded
            return document.fonts.load('1rem FontAwesome')
                .then(() => {
                    fontAwesomeLoaded = true;
                    return fontAwesomeLoaded;
                });
        });
};

export const registerLoadFontAwesome = (promiseFunc) => {
  defaultLoadFontAwesome = promiseFunc;
}

export const loadFontAwesome = () => {
    return defaultLoadFontAwesome();
};

then in a specific project you could use registerLoadFontAwesome in the app entry to override the default function

[mahmoudadel54]

@allyoucanmap
I think the use case we opened this issue is in importing vector layer. In import new vector layer -- > drawIcons method is called and it calls loadFontAwesome within it by default. We don't make exporting this specific method and use it particularly in import.
So I think your approach doesn't prevent calling this method because in import vector layer, calling this method is not optional.

[MV88]

@ElenaGallo can you test this on DEV asap?

[ElenaGallo]

Test passed, @mahmoudadel54 please backport. Thanks