-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control loading FontAwesome for vector style #10711
Comments
MV88
added
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Dec 4, 2024
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this issue
Dec 4, 2024
Description: - add boolean cfg called 'loadFontAwesomeForIcons' for Map plugin to control the loading fontAwesome for vector style - add jsdocs in plugin/Map - handle the control of loading fontAwesome for openlayers, leaflet and cesium
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this issue
Dec 4, 2024
Description: - add boolean cfg called 'loadFontAwesomeForIcons' for Map plugin to control the loading fontAwesome for vector style - add jsdocs in plugin/Map - handle the control of loading fontAwesome for openlayers, leaflet and cesium
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this issue
Dec 4, 2024
Description: - add boolean cfg called 'loadFontAwesomeForIcons' for Map plugin to control the loading fontAwesome for vector style - add jsdocs in plugin/Map - handle the control of loading fontAwesome for openlayers, leaflet and cesium
mahmoudadel54
changed the title
Control loading FontAwsome for vector style
Control loading FontAwesome for vector style
Dec 4, 2024
12 tasks
12 tasks
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this issue
Dec 4, 2024
…nd loadFontAwesomeForIcons = true --> it will load fontAwesome and if there is no icons ---> it won't load
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this issue
Dec 9, 2024
…ocalConfig instead of map plugin and revert other changes
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this issue
Dec 9, 2024
MV88
pushed a commit
that referenced
this issue
Dec 9, 2024
* #10711: Control loading FontAwsome for vector style Description: - add boolean cfg called 'loadFontAwesomeForIcons' for Map plugin to control the loading fontAwesome for vector style - add jsdocs in plugin/Map - handle the control of loading fontAwesome for openlayers, leaflet and cesium * #10711: enhance drawIcons if there are icons in data and loadFontAwesomeForIcons = true --> it will load fontAwesome and if there is no icons ---> it won't load * #10711: using cfg loadFontAwesomeForIcons in root in localConfig instead of map plugin and revert other changes * #10711: remove unused console.log in StylePArserUtils
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this issue
Dec 18, 2024
…eosolutions-it#10715) * geosolutions-it#10711: Control loading FontAwsome for vector style Description: - add boolean cfg called 'loadFontAwesomeForIcons' for Map plugin to control the loading fontAwesome for vector style - add jsdocs in plugin/Map - handle the control of loading fontAwesome for openlayers, leaflet and cesium * geosolutions-it#10711: enhance drawIcons if there are icons in data and loadFontAwesomeForIcons = true --> it will load fontAwesome and if there is no icons ---> it won't load * geosolutions-it#10711: using cfg loadFontAwesomeForIcons in root in localConfig instead of map plugin and revert other changes * geosolutions-it#10711: remove unused console.log in StylePArserUtils
MV88
pushed a commit
that referenced
this issue
Dec 19, 2024
* #10711: Control loading FontAwsome for vector style Description: - add boolean cfg called 'loadFontAwesomeForIcons' for Map plugin to control the loading fontAwesome for vector style - add jsdocs in plugin/Map - handle the control of loading fontAwesome for openlayers, leaflet and cesium * #10711: enhance drawIcons if there are icons in data and loadFontAwesomeForIcons = true --> it will load fontAwesome and if there is no icons ---> it won't load * #10711: using cfg loadFontAwesomeForIcons in root in localConfig instead of map plugin and revert other changes * #10711: remove unused console.log in StylePArserUtils
ElenaGallo
removed
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
This issue is for enhancement the way of loading fontawesome for vector style for icons implemented here:
MapStore2/web/client/utils/styleparser/StyleParserUtils.js
Lines 920 to 935 in 831eab5
The current implementation is loading the fontawesome whatever the data has icons or not.
The main use case for this issue is [When uploading shapefiles with vector data, there's no need to load the FontAwesome style,] because:
So we need:
Other useful information
The text was updated successfully, but these errors were encountered: