Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2024.02.xx] #10711: Control loading FontAwesome for vector style (#10715) #10730

Merged

Conversation

mahmoudadel54
Copy link
Contributor

This PR is [Backport 2024.02.xx] #10711: Control loading FontAwesome for vector style (#10715)

…eosolutions-it#10715)

* geosolutions-it#10711: Control loading FontAwsome for vector style
Description:
- add boolean cfg called 'loadFontAwesomeForIcons' for Map plugin to control the loading fontAwesome for vector style
- add jsdocs in plugin/Map
- handle the control of loading fontAwesome for openlayers, leaflet and cesium

* geosolutions-it#10711: enhance drawIcons if there are icons in data and loadFontAwesomeForIcons = true --> it will load fontAwesome and if there is no icons ---> it won't load

* geosolutions-it#10711: using cfg loadFontAwesomeForIcons in root in localConfig instead of map plugin and revert other changes

* geosolutions-it#10711: remove unused console.log in StylePArserUtils
@mahmoudadel54 mahmoudadel54 added this to the 2025.01.00 milestone Dec 18, 2024
@mahmoudadel54 mahmoudadel54 requested a review from MV88 December 18, 2024 10:03
@mahmoudadel54 mahmoudadel54 self-assigned this Dec 18, 2024
@mahmoudadel54 mahmoudadel54 linked an issue Dec 18, 2024 that may be closed by this pull request
@MV88 MV88 marked this pull request as ready for review December 19, 2024 16:31
@MV88 MV88 merged commit 35356f5 into geosolutions-it:2024.02.xx Dec 19, 2024
6 checks passed
@MV88
Copy link
Contributor

MV88 commented Dec 19, 2024

@ElenaGallo testable in QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control loading FontAwesome for vector style
2 participants