Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ign-gazebo6 ➡️ main (part 3/3) #1633

Merged
merged 26 commits into from
Aug 10, 2022
Merged

Merge ign-gazebo6 ➡️ main (part 3/3) #1633

merged 26 commits into from
Aug 10, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Aug 8, 2022

➡️ Forward port

Port ign-gazebo6 ➡️ main

Branch comparison: main...ign-gazebo6

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

Blast545 and others added 24 commits June 23, 2022 12:19
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>

Co-authored-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
This test fails to compile with the latest version
of protobuf, which is currently available on macOS.

Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
This test fails to compile with the latest version
of protobuf, which is currently available on macOS.

Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: youhy <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Andrew Ealovega <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
* Ackermann Steering Plugin (#618)

Signed-off-by: Kevin <[email protected]>

Co-authored-by: Kevin <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>

* Using math::SpeedLimiter on the ackermann_steering controller. (#837)

Signed-off-by: LolaSegura <[email protected]>

* Add Tf publishing to AckermannSteering system (#1576)

Signed-off-by: Andrew Ealovega <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>

Co-authored-by: knoedler <[email protected]>
Co-authored-by: Kevin <[email protected]>
Co-authored-by: LolaSegura <[email protected]>
Co-authored-by: Andrew Ealovega <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Steve Peters <[email protected]>

Co-authored-by: Steve Peters <[email protected]>
Signed-off-by: Mohamad <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Mohamad <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested review from iche033 and azeey as code owners August 8, 2022 22:43
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 8, 2022
@chapulina chapulina changed the base branch from main to chapulina/6_to_7_pt2 August 8, 2022 22:43
@chapulina chapulina changed the title Merge ign-gazebo6 ➡️ main Merge ign-gazebo6 ➡️ main (part 3/3) Aug 8, 2022
Base automatically changed from chapulina/6_to_7_pt2 to main August 9, 2022 15:09
@mjcarroll
Copy link
Contributor

Have you verified that the demo worlds as part of the quick start GUI are functional on Garden? I seem to recall trying one or two and they still used Scene3d.

@chapulina
Copy link
Contributor Author

Have you verified that the demo worlds as part of the quick start GUI are functional on Garden? I seem to recall trying one or two and they still used Scene3d.

Yeah I just checked this. I'm going to open a separate PR loading MinimalScene + others when GzScene3d is requested.

Btw, I'm updating this PR. Will ping reviewers when it's open for review again.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina force-pushed the chapulina/6_to_7_pt3 branch from 30a312f to ac6e9e0 Compare August 9, 2022 19:14
chapulina added a commit that referenced this pull request Aug 9, 2022
Signed-off-by: Louise Poubel <[email protected]>
chapulina added a commit that referenced this pull request Aug 9, 2022
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina force-pushed the chapulina/6_to_7_pt3 branch from 8e82cd5 to ebcce09 Compare August 9, 2022 20:35
@chapulina
Copy link
Contributor Author

Have you verified that the demo worlds as part of the quick start GUI are functional on Garden? I seem to recall trying one or two and they still used Scene3d.

chapulina added a commit that referenced this pull request Aug 9, 2022
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina force-pushed the chapulina/6_to_7_pt3 branch from ebcce09 to eef117a Compare August 9, 2022 22:58
@chapulina chapulina requested a review from mjcarroll August 10, 2022 15:26
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple more igns

src/gui/Gui_TEST.cc Outdated Show resolved Hide resolved
src/gui/Gui_TEST.cc Outdated Show resolved Hide resolved
src/gui/Gui_TEST.cc Outdated Show resolved Hide resolved
src/gui/Gui_TEST.cc Outdated Show resolved Hide resolved
src/gui/Gui_TEST.cc Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina force-pushed the chapulina/6_to_7_pt3 branch from eef117a to 9265793 Compare August 10, 2022 15:52
@chapulina
Copy link
Contributor Author

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1633 (9265793) into main (f8deb17) will increase coverage by 0.40%.
The diff coverage is 77.50%.

@@            Coverage Diff             @@
##             main    #1633      +/-   ##
==========================================
+ Coverage   63.47%   63.87%   +0.40%     
==========================================
  Files         331      334       +3     
  Lines       26123    26373     +250     
==========================================
+ Hits        16581    16847     +266     
+ Misses       9542     9526      -16     
Impacted Files Coverage Δ
include/gz/sim/Model.hh 100.00% <ø> (ø)
include/gz/sim/ServerConfig.hh 100.00% <ø> (ø)
include/gz/sim/Util.hh 100.00% <ø> (ø)
src/LevelManager.cc 89.19% <ø> (ø)
src/SdfEntityCreator.cc 85.55% <ø> (ø)
src/rendering/MarkerManager.cc 13.02% <0.00%> (ø)
src/rendering/SceneManager.cc 28.34% <0.00%> (ø)
...rc/systems/ackermann_steering/AckermannSteering.hh 100.00% <ø> (ø)
src/systems/sensors/Sensors.cc 63.00% <0.00%> (ø)
src/gz.cc 64.97% <23.33%> (-7.88%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chapulina chapulina merged commit d90fab2 into main Aug 10, 2022
@chapulina chapulina deleted the chapulina/6_to_7_pt3 branch August 10, 2022 17:24
@chapulina chapulina mentioned this pull request Aug 11, 2022
8 tasks
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

10 participants