fix: 🐛 Enhance hostname prompt error handling #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4c6da6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
heldrida
changed the title
kkudryaev
previously approved these changes
Oct 28, 2024
…lid-app-hostname-show-text-error
gabrielmpinto
pushed a commit
that referenced
this pull request
Oct 28, 2024
Enhance hostname error messaging. - In the application update, show an invalid hostname warning message for each invalid hostname - Show the prompt repeatedly until valid hostname's provided by the user - [PLAT-1664](https://linear.app/fleekxyz/issue/PLAT-1664/on-invalid-application-value-show-text-error-message-not-json) - [x] The commit messages are detailed - [x] The `build` command runs locally - [ ] Assets or static content are linked and stored in the project - [x] You have manually tested - [ ] You have provided tests - [ ] Sensitive data has been identified and is being protected properly - [ ] Injection has been prevented (parameterized queries, no eval or system calls) Optionally, provide the preview url here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Enhance hostname error messaging.
How?
Tickets?
Contribution checklist?
buildcommand runs locallySecurity checklist?
Preview?
Optionally, provide the preview url here