Skip to content

Commit

Permalink
fix: 🐛 Enhance hostname prompt error handling (#48)
Browse files Browse the repository at this point in the history
Enhance hostname error messaging.

- In the application update, show an invalid hostname warning message
for each invalid hostname
- Show the prompt repeatedly until valid hostname's provided by the user

-
[PLAT-1664](https://linear.app/fleekxyz/issue/PLAT-1664/on-invalid-application-value-show-text-error-message-not-json)

- [x] The commit messages are detailed
- [x] The `build` command runs locally
- [ ] Assets or static content are linked and stored in the project
- [x] You have manually tested
- [ ] You have provided tests

- [ ] Sensitive data has been identified and is being protected properly
- [ ] Injection has been prevented (parameterized queries, no eval or
system calls)

Optionally, provide the preview url here
  • Loading branch information
heldrida authored and gabrielmpinto committed Oct 28, 2024
1 parent 4e5d630 commit c52ed32
Show file tree
Hide file tree
Showing 7 changed files with 5,515 additions and 4,380 deletions.
5 changes: 5 additions & 0 deletions .changeset/blue-onions-worry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@fleek-platform/cli": minor
---

Enhance hostname prompt error handling
2 changes: 1 addition & 1 deletion .github/workflows/code-format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:

- name: Install dependencies
run: |
pnpm install
pnpm i
- name: Code format check
id: fmt_check
Expand Down
3 changes: 2 additions & 1 deletion locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -356,5 +356,6 @@
"uploadingAssets": "Uploading assets...",
"assetsUploadSuccess": "Assets uploaded successfully",
"uploadAssetsFailed": "Failed to upload assets for function",
"assetsNotSupportedInSgx": "Function assets are not supported in SGX"
"assetsNotSupportedInSgx": "Function assets are not supported in SGX",
"invalidHostname": "Invalid hostname `{hostname}`. Please try again!"
}
Loading

0 comments on commit c52ed32

Please sign in to comment.