Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow duplicated puts in robustness #18772

Closed
wants to merge 14 commits into from

Conversation

serathius
Copy link
Member

@serathius serathius commented Oct 23, 2024

Rewrite patching history, so instead of patching only puts by assuming all of them are unique, rather count client calls and only allow patching for writes that were called once.

This is needed to implement Kubernetes like compaction that reuses same key.

cc @ah8ad3 @ahrtr @MadhavJivrajani @henrybear327

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (6de50f9) to head (33d433a).

Current head 33d433a differs from pull request most recent head 87727e0

Please upload reports for the commit 87727e0 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18772      +/-   ##
==========================================
+ Coverage   68.69%   68.74%   +0.04%     
==========================================
  Files         420      420              
  Lines       35558    35558              
==========================================
+ Hits        24427    24443      +16     
+ Misses       9695     9687       -8     
+ Partials     1436     1428       -8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de50f9...87727e0. Read the comment docs.

@serathius
Copy link
Member Author

/retest

@serathius
Copy link
Member Author

ping @ahrtr

@serathius
Copy link
Member Author

cc @siyuanfoundation

@serathius
Copy link
Member Author

cc @jmhbnz

@k8s-ci-robot
Copy link

@serathius: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-unit-test-386 87727e0 link true /test pull-etcd-unit-test-386

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@serathius
Copy link
Member Author

Let's split it into smaller PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants