Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustness refactor patch operations #18903

Merged

Conversation

serathius
Copy link
Member

First stage for #18772

We clean up the patchOperations functions to be simpler and use switch allowing support for other commands.

cc @ah8ad3 @ahrtr @MadhavJivrajani @henrybear327 @siyuanfoundation @jmhbnz

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.70%. Comparing base (6de50f9) to head (12bac53).

Current head 12bac53 differs from pull request most recent head 4a1855e

Please upload reports for the commit 4a1855e to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 21 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #18903   +/-   ##
=======================================
  Coverage   68.69%   68.70%           
=======================================
  Files         420      420           
  Lines       35558    35558           
=======================================
+ Hits        24427    24430    +3     
- Misses       9695     9700    +5     
+ Partials     1436     1428    -8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de50f9...4a1855e. Read the comment docs.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Many thanks for breaking this into both smaller commits and separate pr's @serathius it was much easier to review compared to the full initial pr we stepped through at KubeCon.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit cfdd69f into etcd-io:main Nov 16, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants