Robustness duplicated puts 2 #18904
Robustness duplicated puts 2 #18904
Conversation
serathius
force-pushed
the
robustness-duplicated-puts-2
branch
2 times, most recently
from
4e4c74f
to
b0ca3a0
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 19 files with indirect coverage changes @@ Coverage Diff @@
## main #18904 +/- ##
==========================================
+ Coverage 68.68% 68.69% +0.01%
==========================================
Files 420 420
Lines 35558 35558
==========================================
+ Hits 24424 24428 +4
+ Misses 9704 9699 -5
- Partials 1430 1431 +1 Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Marek Siarkowicz <[email protected]>
Signed-off-by: Marek Siarkowicz <[email protected]>
Signed-off-by: Marek Siarkowicz <[email protected]>
Signed-off-by: Marek Siarkowicz <[email protected]>
serathius
force-pushed
the
robustness-duplicated-puts-2
branch
from
b0ca3a0
to
6d00e7b
Compare
| case model.RangeOperation: | ||
| case model.PutOperation: | ||
| kv := keyValue{Key: event.Key, Value: event.Value} | ||
| requestRevision[kv] = event.Revision |
There was a problem hiding this comment.
Is it required to check revision should not be decreased here for same key/value? The validateOrdered already covers that. It will be good to add some comments here.
There was a problem hiding this comment.
There can only be one revision assigned to a unique write, we only patch unique writes like put, case you described should never happen. We do that for return time because its just estimation it based on different sources, like client response time, watch events and following write.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fuweid, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Spitted from #18772
cc @ah8ad3 @ahrtr @MadhavJivrajani @henrybear327 @siyuanfoundation @jmhbnz