Move time spine and fill nulls rendering tests to separate module #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this, the splitting up of test_dataflow_to_sql_plan into direct tests of the object conversion rendering (still in test_dataflow_to_sql_plan) and more feature-specific query rendering (now in the tests/query_rendering package) is complete.
This was referenced Nov 3, 2023
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
1 similar comment
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tlento
changed the title
tlento
added
the
Run Tests With Other SQL Engines
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
courtneyholcomb
approved these changes
Nov 3, 2023
tlento
deleted the
11-02-Move_time_spine_and_fill_nulls_rendering_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, the splitting up of test_dataflow_to_sql_plan into
direct tests of the object conversion rendering (still in
test_dataflow_to_sql_plan) and more feature-specific query
rendering (now in the tests/query_rendering package) is complete.