Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cumulative metric query rendering tests to new module #837

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

tlento
Copy link
Contributor

@tlento tlento commented Nov 2, 2023

The test_dataflow_to_sql_plan module is being broken up
into smaller pieces. This one covers all cumulative metric
rendering tests.

The test_dataflow_to_sql_plan module is being broken up
into smaller pieces. This one covers all cumulative metric
rendering tests.
@cla-bot cla-bot bot added the cla:yes label Nov 2, 2023
Copy link

github-actions bot commented Nov 2, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
Copy link

github-actions bot commented Nov 2, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@courtneyholcomb
Copy link
Contributor

Was it intentional that you deleted the SqlQueryPlan snapshots in metricflow/test/snapshots/test_dataflow_to_sql_plan.py/SqlQueryPlan/?

@tlento
Copy link
Contributor Author

tlento commented Nov 3, 2023

Was it intentional that you deleted the SqlQueryPlan snapshots in metricflow/test/snapshots/test_dataflow_to_sql_plan.py/SqlQueryPlan/?

Yup! I left a comment on the base PR in the stack where the change was made.

@tlento tlento merged commit dad961f into main Nov 3, 2023
32 of 34 checks passed
@tlento tlento deleted the move-cumulative-metric-rendering-tests branch November 3, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants