Move date part rendering tests to separate module #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the date part rendering tests out of the test_dataflow_to_sql_plan module into their own space. The new module is tagged for both date_part and granularity query rendering, because impending updates to date_part and granularity handling will likely require some additional query rendering tests, and date_part and granularity rendering will be fairly similar in terms of the pattern of the final output.
This was referenced Nov 3, 2023
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
This was referenced Nov 3, 2023
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
courtneyholcomb
approved these changes
Nov 3, 2023
Base automatically changed from
11-02-Move_derived_metric_rendering_tests
to
main
November 3, 2023 02:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the date part rendering tests out of the
test_dataflow_to_sql_plan module into their own space.
The new module is tagged for both date_part and granularity
query rendering, because impending updates to date_part and
granularity handling will likely require some additional
query rendering tests, and date_part and granularity rendering
will be fairly similar in terms of the pattern of the final output.