Fix flaky test related to tracking events #3604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwigley
force-pushed
the
fix/flaky-tracking-tests
branch
from
cdee6ff to
ba13465
Compare
leahwicz
reviewed
Jul 21, 2021
| @@ -9,6 +10,7 @@ | |||
| import dbt.tracking | |||
| import dbt.utils | |||
|
|
|||
| pytestmark = pytest.mark.skip("Experimental parser generates events non-deterministically, skipping.") | |||
There was a problem hiding this comment.
Does this skip all the tests in this file? I don't see pytestmark being used anywhere so I'm not sure how that works
There was a problem hiding this comment.
That is correct, it marks all tests in the module as skipped!
https://docs.pytest.org/en/stable/reference.html#globalvar-pytestmark
There was a problem hiding this comment.
Well, I thought it did. https://github.com/dbt-labs/dbt/pull/3604/checks?check_run_id=3124252846
leahwicz
approved these changes
Jul 21, 2021
nathaniel-may
approved these changes
Jul 21, 2021
kwigley
force-pushed
the
fix/flaky-tracking-tests
branch
from
3311ef3 to
94c3fa3
Compare
kwigley
force-pushed
the
fix/flaky-tracking-tests
branch
from
15261bb to
19150ea
Compare
|
Created #3631 to address root cause. |
leahwicz
pushed a commit
that referenced
this pull request
Jul 29, 2021
* skip all tracking event testing * Turn off tracking in tests that hits model parsing code path fix other random test that fails because global tracking.current_user exists but is null * pytest did not respect skip mark * fix gh actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3561
Description
skipscomment out tests related to event tracking, these are testing non-deterministic behaviorChecklist
CHANGELOG.mdand added information about my change to the "dbt next" section.