fixing typo in test #3610
Merged
fixing typo in test #3610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahwicz
approved these changes
Jul 22, 2021
|
anyone opposed to me merging this without the green? |
kwigley
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I got lucky when I originally merged this change. The events this is testing are non-deterministic so
test_result_A or test_result_Bresolved toTrue or ____and passed. However, in the event we fire a experimental parser sample, it would fail the assertion hence some flake. Thanks to @gshank and @iknox-fa for calling this out.Just to clarify, this is not the only test that has been flaky in this file so I am still pro PR#3604.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.