Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test related to tracking events #3604

Merged
merged 4 commits into from
Jul 26, 2021
Merged

Fix flaky test related to tracking events #3604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9146746
skip all tracking event testing
Jul 21, 2021
b6e3bea
Turn off tracking in tests that hits model parsing code path
Jul 21, 2021
2360950
pytest did not respect skip mark
Jul 26, 2021
19150ea
fix gh actions
Jul 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
- 'develop'
- '*.latest'
- 'releases/*'
pull_request_target:
pull_request:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leahwicz wanted to run this change by you. I was confused why tests weren't picking up my change, I realized the behavior for the pull_request_target event checks out the target branch for the checkout step. I think this is what we want, I'd like to confirm though!

branches:
- 'develop'
- '*.latest'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
- 'develop'
- '*.latest'
- 'releases/*'
pull_request_target: # Trigger for all PRs
pull_request: # Trigger for all PRs
workflow_dispatch: # Allow manual triggers

jobs:
Expand Down
Loading