Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Python 3.11 #754

Merged
merged 27 commits into from
Oct 10, 2023
Merged

Upgrade to Python 3.11 #754

merged 27 commits into from
Oct 10, 2023

Conversation

dmichaels-harvard
Copy link
Contributor

  • Upgrade to Python 3.11.
  • Changed pyyaml version to ^6.0.1.
  • Updated boto versions.
  • Removed types/access_key.py and schemas/access_key.json as the ones in snovault are sufficient.
  • Added generate-local-access-key script (from snovault) to pyproject.toml;
    orignally created for smaht-portal since early in development no way to
    create an access-key normally using the UI; but generall useful/convenient.
  • Added generate-local-access-key script (defined in snovault).
  • Added view-local-object script (defined in snovault).

@dmichaels-harvard
j
ec081f6
@dmichaels-harvard
Comments in CHANGELOG.rst
f215817
@dmichaels-harvard
Changed import of Mapping from collections to collections.abc
0f5dc2e
@dmichaels-harvard
Typo!
7dbf212
@dmichaels-harvard
Update snovault version
e5f396d
@dmichaels-harvard
update version
9f26298
@dmichaels-harvard
TEMPORARILY putting access_key.py/json back to debug GA failure.
27f5a78
@dmichaels-harvard
Update access_key.{json,py} back.
74db13e
@dmichaels-harvard
debug
a2ffd0f
@dmichaels-harvard
Remove 3.11 from .github/workflows/main.yml for testing/debugging pur…
22db0bc 
…poses.
@dmichaels-harvard
Put 3.11 back into .github/workflows/main.yml but removed 3.8 so only…
4024635 
… one.
@dmichaels-harvard
Now put back both 3.8 and 3.11 in .github/workflows/main.yml
393bd25
@dmichaels-harvard
Again remove 3.8 from .github/workflows/main.yml so again there is on…
3f2b191 
…ly one.
@dmichaels-harvard
Added back both 3.8 and 3.11 in .github/workflows/main.yml and added …
1458193 
…wait_for_index in test_create_mapping.py.
@dmichaels-harvard
Backed out both 3.8 and 3.11 from .github/workflows/main.yml - just 3…
c1320f4 
….1 now
willronchetti
willronchetti reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@willronchetti willronchetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in Fourfront - need to bump the Docker base image and deploy/test in devtest

netsettler
netsettler reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@netsettler netsettler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are not blocking.

src/encoded/ingestion/table_utils.py
@@ -3,7 +3,7 @@
import io
import json
import logging
from collections import Mapping
from collections.abc import Mapping
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bleah. Yeah, this is fine. But we see Python 3.11 makes an incompatible change. Sigh. (They might console themselves that they announced it earlier, but not as a 3.0 change. It only had compatibility support added in 3.4.) Once again we see semantic versioning apparently means nothing in Python. :(

pyproject.toml Outdated
@@ -33,13 +33,16 @@ classifiers = [
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.7',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line (about 3.7) should be deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oversight, thanks, deleted.

pyproject.toml
]

[tool.poetry.dependencies]
python = ">=3.8.1,<3.10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we definitely mean 3.8.1 or did you just change the 7 to an 8? Is it not just >=3.8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't change that from master, it used to be: python = ">=3.8.1,<3.10" ... not sure why it would be 3.8.1 ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I recall from a long time ago 3.8.1 has some specific issues with cgap-portal IRC hence the explicit exclusion

willronchetti
willronchetti approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@willronchetti willronchetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving now since integrated testing looks good

@netsettler netsettler mentioned this pull request Oct 4, 2023
Merged
@dmichaels-harvard dmichaels-harvard merged commit 39251e4 into master Oct 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willronchetti willronchetti willronchetti approved these changes

@netsettler netsettler netsettler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmichaels-harvard @netsettler @willronchetti