Use dcicpyvcf version 3 (C4-1106) #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willronchetti
approved these changes
Oct 6, 2023
…csnovault in pyproject.toml, and then update poetry.lock to agree.
dmichaels-harvard
approved these changes
Oct 10, 2023
It's a layered PR, so doesn't need a version bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended as a branch-to-branch PR affecting cgap-portal PR #754 on branch upgrade-python-20230925.
The only proposed changes are to the
dcicpyvcfversion inpyproject.toml, adjusting it from1.0.0.1b0to3.0.0a4in order to test that out. It tests cleanly in Python 3.8.16 on my local machine and this will test it in Python 11. If this test is successful, we plan to release thatdcicpyvcfversion as3.0.0, and I'll adjust that in this PR before we merge it (if this gets approved).The actual change is tiny, just that one line in pyproject.toml and a corresponding invocation of
poetry update dcicpyvcfcausing a change topoetry.lock. But right now I'm showing the PR as merging to master so that I can get easy testing and so it will look like a lot more files are changed, only because those files are changed in David's underlying branch (upgrade-python-20230925).