-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish site via GitHub Actions #349
Conversation
Comment from the linked issue:
I updated |
Another advantage of this moving forward is that to publish the site when we make changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just one question about the them pinning
docker/fuelcycle.org-deps/Dockerfile
Outdated
RUN pip3 install sphinx sphinxcontrib-bibtex | ||
RUN pip3 install cloud-sptheme==1.6 | ||
RUN apt-get install -y --force-yes wget python3-pip | ||
RUN python -m pip install sphinx sphinxcontrib-bibtex cloud-sptheme==1.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this pinning to preserve the sidebar menu? If so, let's add an issue to update our templates for a newer theme version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why it is pinned at 1.6, that's just what was there. I'll make an issue regardless and try to resolve the sidebar complications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not for any reason, maybe let's drop the pin and see what we get?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dropped the pin and don't notice any significant changes (if any at all). If you want you can download the artifact generated by the action and check it out yourself! 😃
https://github.com/cyclus/cyclus.github.com/actions/runs/8461607773
Closes #344. Instead of maintaining a
main
branch to publish the site this will publish the site via a GitHub workflow on any merge tosource
. Attempting to follow best practices outlined in GitHub documentation.