Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing from master instead of main #347

Closed
abachma2 opened this issue Mar 22, 2024 · 9 comments
Closed

Publishing from master instead of main #347

abachma2 opened this issue Mar 22, 2024 · 9 comments
Assignees

Comments

@abachma2
Copy link
Member

With the changes in #345 and #346 it looks like the website is still published from the master branch and not the main branch like it should be. This may be why some of the most recent changes are not captured in the current version of the site.

@gonuke
Copy link
Member

gonuke commented Mar 22, 2024

I think it's something different from that.

  1. I didn't rebuild/republish to main
  2. There is another PR that includes more comprehensive updates from master -> main

@abachma2
Copy link
Member Author

OK. I thought that had already been merged. Merging #341 will close this issue then.

@gonuke
Copy link
Member

gonuke commented Mar 22, 2024

#341 is now merged, but someone needs to rebuild/publish the website to see final updates

@abachma2
Copy link
Member Author

I tried to build it, it all runs fine, but I'm not sure it actually includes all of the updates made in #335.

@gonuke
Copy link
Member

gonuke commented Mar 22, 2024

It might be because of errors in the build? I noticed that cep0 doesn't render correctly with the new CEP 29 showing up in the directory

@abachma2
Copy link
Member Author

Maybe, because the changes from #340 are present.

@gonuke gonuke moved this to In Progress in March 2024 Hack-a-thon Mar 29, 2024
@bennibbelink
Copy link
Contributor

Is this issue still relevant after #349 was merged?

@abachma2
Copy link
Member Author

abachma2 commented Apr 1, 2024

Let me try building the website from the source branch and see what happens.

@abachma2
Copy link
Member Author

abachma2 commented Apr 1, 2024

Based on the terminal output, all the build commands are pointing to the main branch. The main point of this issue is resolved, so I'll close the issue.

@abachma2 abachma2 closed this as completed Apr 1, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in March 2024 Hack-a-thon Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants