Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Update #591

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Conversation

bennibbelink
Copy link
Contributor

The biggest changes are master to main. I also updated the Ubuntu versions and changed the links to point to our GitHub releases.

The minimum required Cyclus version will need to be updated again when we issue the new release.

I will make a separate PR for documenting our container images as an installation option.

Copy link

github-actions bot commented Mar 25, 2024

Build Status Report - 95adfa1 - 2024-03-25 22:48:08 +0000

Build FROM cyclus_20.04_apt/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_20.04_apt/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_conda/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_20.04_conda/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_apt/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_22.04_apt/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_conda/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_22.04_conda/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bennibbelink - this looks good. Do we merge ASAP, or do we need to do the release first/simultaneously? I ask because the (working/up-to-date) DEB packages don't actually exist yet, do they?

@bennibbelink
Copy link
Contributor Author

Good point, we should probably wait until the release.

@gonuke
Copy link
Member

gonuke commented Mar 26, 2024

It does create a bit of a race condition... since it would be good to update docs as much as possible before release :)

@bennibbelink
Copy link
Contributor Author

I wonder if maybe in the cyclus.github.com #349 we should use the cymetric:stable version (after release of course so the image actually exists). That way we could have a working version of the docs on main prior to a release, but they won't actually be published to the site until the next release.

Up to you whether we merge this PR now or wait. The DEB package links are broken now anyway - changing the broken links for different broken links doesn't sound like the end of the world

@gonuke
Copy link
Member

gonuke commented Apr 2, 2024

Thanks @bennibbelink - let's do this now and revisit what we need to at release time

@gonuke gonuke merged commit 24bb0e3 into cyclus:main Apr 2, 2024
10 checks passed
@bennibbelink bennibbelink deleted the dependency-versions branch April 2, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants