Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kola test for local dir container deployment #4624

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions tests/kolainst/destructive/container-deploy
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
#!/bin/bash
# This test reboots a lot, generates container images, etc.
# kola: { "timeoutMin": 30 }
#
# Copyright (C) 2021 Red Hat, Inc.
#
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
# License as published by the Free Software Foundation; either
# version 2 of the License, or (at your option) any later version.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with this library; if not, write to the
# Free Software Foundation, Inc., 59 Temple Place - Suite 330,
# Boston, MA 02111-1307, USA.

set -euo pipefail

. ${KOLA_EXT_DATA}/libtest.sh

set -x

libtest_prepare_offline
cd "$(mktemp -d)"

# TODO: It'd be much better to test this via a registry
image_dir=/var/tmp/fcos
image=dir:$image_dir

checksum=$(rpm-ostree status --json | jq -r '.deployments[0].checksum')
rm ${image_dir} -rf

# Since we're switching OS update stream, turn off zincati
systemctl mask --now zincati

ostree container encapsulate --repo=/ostree/repo ${checksum} "${image}"

mkdir /var/tmp/sysroot
ostree admin init-fs --modern /var/tmp/sysroot
ostree admin os-init fedora-coreos --sysroot /var/tmp/sysroot
ostree container image deploy --imgref ostree-unverified-image:dir:/var/tmp/fcos --sysroot /var/tmp/sysroot --stateroot fedora-coreos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So...I'm OK having this here, but I think it'd be better to have it in the ostree tests (sorry I should have mentioned this).

Around here https://github.com/ostreedev/ostree-rs-ext/blob/88b5fc7083a97806c79fbdbbe9e06af9e7cad2f5/ci/priv-integration.sh#L107

This would let the test pass right now, without waiting for an -ext release and an update here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sure thing, I'll write it on theostree side instead. Should we close this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, probably close here. One issue is that the way this test works is a bit slow (encapsulating and then immediately unencapsulating again) and it's probably not worth running on every PR here.