-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kola
test for local dir container deployment
#4624
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
#!/bin/bash | ||
# This test reboots a lot, generates container images, etc. | ||
# kola: { "timeoutMin": 30 } | ||
# | ||
# Copyright (C) 2021 Red Hat, Inc. | ||
# | ||
# This library is free software; you can redistribute it and/or | ||
# modify it under the terms of the GNU Lesser General Public | ||
# License as published by the Free Software Foundation; either | ||
# version 2 of the License, or (at your option) any later version. | ||
# | ||
# This library is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
# Lesser General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU Lesser General Public | ||
# License along with this library; if not, write to the | ||
# Free Software Foundation, Inc., 59 Temple Place - Suite 330, | ||
# Boston, MA 02111-1307, USA. | ||
|
||
set -euo pipefail | ||
|
||
. ${KOLA_EXT_DATA}/libtest.sh | ||
|
||
set -x | ||
|
||
libtest_prepare_offline | ||
cd "$(mktemp -d)" | ||
|
||
# TODO: It'd be much better to test this via a registry | ||
image_dir=/var/tmp/fcos | ||
image=dir:$image_dir | ||
|
||
checksum=$(rpm-ostree status --json | jq -r '.deployments[0].checksum') | ||
rm ${image_dir} -rf | ||
|
||
# Since we're switching OS update stream, turn off zincati | ||
systemctl mask --now zincati | ||
|
||
ostree container encapsulate --repo=/ostree/repo ${checksum} "${image}" | ||
|
||
mkdir /var/tmp/sysroot | ||
ostree admin init-fs --modern /var/tmp/sysroot | ||
ostree admin os-init fedora-coreos --sysroot /var/tmp/sysroot | ||
ostree container image deploy --imgref ostree-unverified-image:dir:/var/tmp/fcos --sysroot /var/tmp/sysroot --stateroot fedora-coreos | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So...I'm OK having this here, but I think it'd be better to have it in the ostree tests (sorry I should have mentioned this).
Around here https://github.com/ostreedev/ostree-rs-ext/blob/88b5fc7083a97806c79fbdbbe9e06af9e7cad2f5/ci/priv-integration.sh#L107
This would let the test pass right now, without waiting for an -ext release and an update here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sure thing, I'll write it on the
ostree
side instead. Should we close this PR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, probably close here. One issue is that the way this test works is a bit slow (encapsulating and then immediately unencapsulating again) and it's probably not worth running on every PR here.