-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kola
test for local dir container deployment
#4624
Conversation
This change adds a test for deploying FCOS from a container image stored in a local directory. The test is needed for a change in ostree-rs-ext which adds support for the `dir` transport. In this test, the encapsulate function is used to store the current state of the system to a local directory and is deployed to a temporary sysroot.
f1fbaab
to
e878b98
Compare
mkdir /var/tmp/sysroot | ||
ostree admin init-fs --modern /var/tmp/sysroot | ||
ostree admin os-init fedora-coreos --sysroot /var/tmp/sysroot | ||
ostree container image deploy --imgref ostree-unverified-image:dir:/var/tmp/fcos --sysroot /var/tmp/sysroot --stateroot fedora-coreos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So...I'm OK having this here, but I think it'd be better to have it in the ostree tests (sorry I should have mentioned this).
This would let the test pass right now, without waiting for an -ext release and an update here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sure thing, I'll write it on theostree
side instead. Should we close this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, probably close here. One issue is that the way this test works is a bit slow (encapsulating and then immediately unencapsulating again) and it's probably not worth running on every PR here.
@lukewarmtemp: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Moved to ostreedev/ostree-rs-ext#547 |
This change adds a test for deploying FCOS from a container image stored in a local directory. The test is needed for a change in ostree-rs-ext which adds support for the
dir
transport: ostreedev/ostree-rs-ext#544In this test, the encapsulate function is used to store the current state of the system to a local directory and is deployed to a temporary sysroot.