[STACKED #1228] [ENH] Grpc Coordinator/SysDB #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
HammadB
changed the title
HammadB
commented
Oct 11, 2023
HammadB
commented
Oct 11, 2023
There was a problem hiding this comment.
todo: factor out the services that are not core data models
There was a problem hiding this comment.
Will do in follow-up PR, is a separate concern.
HammadB
force-pushed
the
hammad/coordinator_sysdb
branch
from
0cdb5d7 to
6310595
Compare
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
HammadB
changed the title
HammadB
commented
Oct 12, 2023
| @@ -35,8 +37,19 @@ def sqlite_persistent() -> Generator[SysDB, None, None]: | |||
| shutil.rmtree(save_path) | |||
|
|
|||
|
|
|||
| def grpc_with_mock_server() -> Generator[SysDB, None, None]: | |||
There was a problem hiding this comment.
Adds a test fixture
|
test failures are just a config key bug, will patch. |
1 task
HammadB
force-pushed
the
hammad/coordinator_sysdb
branch
from
6310595 to
2b150e6
Compare
This was referenced Oct 13, 2023
HammadB
force-pushed
the
hammad/coordinator_sysdb
branch
from
6fd33f9 to
f35e576
Compare
HammadB
force-pushed
the
hammad/coordinator_sysdb
branch
from
f35e576 to
f2cf8a6
Compare
HammadB
force-pushed
the
hammad/coordinator_sysdb
branch
from
f2cf8a6 to
b25c8bd
Compare
HammadB
added a commit
that referenced
this pull request
Oct 16, 2023
… creation into SysDB using the policy (#1237) ## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Adds a CollectionAssignmentPolicy and moves topic creation down into SysDB - Changes SysDB to not accept a Collection Object in create_collection() but params instead - New functionality - None TODO: - [ ] delete topic should also live in the sysdb now. ## Test plan *How are these changes tested?* Existing tests were modified with the refactor and ensured to pass. ## Documentation Changes None required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR is stacked on #1228, please TAL at that before this.
Summarize the changes made by this PR.
Will address the following open questions in stacked PRs!
Open questions/issues:
This requires some thought if we use hashing then we can just map the collection onto a topic and store it. Will we ever want to shard a collection across topics?
I don't think this is needed at this moment!
This is conceptually simple, we make topic creation implicitly part of sysdb create collection
I address this in [STACKED #1229] [ENH] Add a CollectionAssignmentPolicy and move topic creation into SysDB using the policy #1237
This is conceptually simple, we just move this logic into sysdb and make it aware of it
I address this in [STACKED #1237] [ENH] Move get_or_create into sysdb #1242
Test plan
How are these changes tested?
I added a mock gRPC server that implements the basic functionality of sysdb with in memory data structures.
We will run the coordinator tests with this impl in the bin/cluster test once the go coordinator service is ready from @Ishiihara
Documentation Changes
None required.