[CLN] Move protos into IDL folder. #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
HammadB
commented
Oct 11, 2023
3 tasks
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
HammadB
changed the title
1 task
This was referenced Oct 13, 2023
HammadB
added a commit
that referenced
this pull request
Oct 16, 2023
## Description of changes This PR is stacked on #1228, please TAL at that before this. *Summarize the changes made by this PR.* - Improvements & Bug fixes - n/a - New functionality - Introduced a grpc sysdb implementation. - Migrate the protobufs to support Null vs Presence where needed. - Added minimal protobuf definitions to implement the grpc coordinator - Add a mock grpc sysdb server that reimplements the core functionality in memory for testing. Will address the following open questions in stacked PRs! Open questions/issues: - [x] Collection <> Topic Mapping _This requires some thought if we use hashing then we can just map the collection onto a topic and store it. Will we ever want to shard a collection across topics?_ I don't think this is needed at this moment! - [x] Topic management moving to sysdb interface _This is conceptually simple, we make topic creation implicitly part of sysdb create collection_ I address this in #1237 - [x] We need to move the get_or_create concept into sysdb _This is conceptually simple, we just move this logic into sysdb and make it aware of it_ I address this in #1242 ## Test plan *How are these changes tested?* I added a mock gRPC server that implements the basic functionality of sysdb with in memory data structures. We will run the coordinator tests with this impl in the bin/cluster test once the go coordinator service is ready from @Ishiihara ## Documentation Changes None required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
Existing Tests
Documentation Changes
None