[Bug]: Explicit return in __init__()

[Sai-Suraj-27]

What happened?

In the following 2 __init__() methods,

chroma/chromadb/db/impl/grpc/client.py

Lines 55 to 59 in 47447b6

	def __init__(self, system: System):
	self._coordinator_url = system.settings.require("chroma_coordinator_host")
	# TODO: break out coordinator_port into a separate setting?
	self._coordinator_port = system.settings.require("chroma_server_grpc_port")
	return super().__init__(system)

chroma/chromadb/db/impl/grpc/server.py

Lines 56 to 59 in 47447b6

	def __init__(self, system: System):
	self._server_port = system.settings.require("chroma_server_grpc_port")
	self._assignment_policy = system.instance(CollectionAssignmentPolicy)
	return super().__init__(system)

We are returning a non-None value.
As per the official docs of Python. Returning a non-None value from an init method causes TypeError to be raised at the runtime.

Versions

Python 3.8, 3.9, 3.10

Relevant log output

No response

[Sai-Suraj-27]

Hey, @HammadB I see that you implemented these 2 classes (#1229). Can you please look into this. Thank you.

[jeffchuber]

@tazarov can you take a look here?

[tazarov]

hey @Sai-Suraj-27, have you excluded the possibility that parent classes' __init__ returns None and these statements, granted a bit confusing knowing that __init__ shouldn't return, are just fine?

The team emphasizes on correctness through testing, so if, as you suggest this returns a non-None value thus rasing TypeError, it will show up in testing.

Feel free to clean up this nit, but note as with other distributed parts of the codebase, things are fluid and there may as well already be branches (not yet PRs) that address this or change it altogether.