-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change behavior of choco list
to be local only
#158
Comments
I love the idea of this - I want to get an idea of what it may require from other tools as this would be a breaking change. |
|
Search and list are aliases |
👍 |
Agreed on |
@christianrondeau I would instinctively assume @ferventcoder Can this please happen in 0.9.9.7? It's intuitive ( |
@alexchandel it's intuitive for you but it is a breaking change, so that's why the milestone is 1.0.0. Folks need time to prepare for the break. |
@alexchandel and it is used by applications that are building on top of chocolatey. |
@ferventcoder Is there any application known to use |
puppet choco provider / chef cookbook / boxstarter |
@ferventcoder So from what I saw, the three packages you mentioned all use |
@gep13 Does this break us with new provider? I know the old one used OData directly. |
@RichiCoder1 maybe? It is going to follow a semver break boundary, likely v1. |
If that's the case, then we'll probably have fixed the gui to use chocolib by then and it'll be a non-issue. |
@RichiCoder1 yes, we are likely to run into some issues with this. But as you say, switching to the use of the lib will ultimately be the correct path forward. |
@ferventcoder Can this please happen? I ended up with a corrupted XML settings file after I had to Control+C to stop an accidental |
@alexchandel Absolutely. Note that we've already set a milestone and version for this. |
A milestone is great, but do we have a timeline on where it falls along that path, or a release timeline up to 1.0 somewhere? EDIT: Especially since this particular issue has been open for... coming up on 4 years now? |
@vexx32 understand the timings are slower than you might like, but it's something that must be moved and transitioned on slowly - otherwise we break many things (and it's likely we would anyway because sometimes folks don't read, but at least they've had the potential to do so). |
@ferventcoder I'm merely commenting on the timeline because most products have a fairly regular breaking changes pattern that is well fleshed out, and also because a target without a set date tends to get forgotten very quickly. As a handful of the folks in the PowerShell slack/discord mentioned, it might be worth implementing it as a optional configurable feature first; that way it won't break anything in its default configuration. If we also are able to track in some unobtrusive method which features like this are being used and on what % of machines, we can then look at defining more concrete timeline of swapping which is default, and eventually deprecating the lesser-used option if it falls out of use. |
(#158) Relegate the -lo/-li warning to log-file-only
After some internal discussion with the team, we've decided to go ahead with ignoring |
And also add an exit code, as it will be likely completely breaking in v3 and possibly causing problems.
And also add an exit code, as it will be likely completely breaking in v3 and possibly causing problems.
And also add an exit code, as it will be likely completely breaking in v3 and possibly causing problems.
And also add an exit code, as it will be likely completely breaking in v3 and possibly causing problems.
(#158) Restore `list -lo` warning when not using -r
For compat with existing tooling, we want -r to keep working, but for interactive use we want to error so users are properly aware that this functionality has changed.
For compat with existing tooling, we want -r to keep working, but for interactive use we want to error so users are properly aware that this functionality has changed.
choco list
to be local onlychoco list
to be local only
🎉 This issue has been resolved in version 2.0.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
* master: (148 commits) (#948) Add user as sensitive argument (#158) Error on list -lo without -r (doc) Update description of page-size argument (#158) Restore -lo warning when not using -r (#158) Update tests (#158) Relegate the -lo warning to log-file-only (#3165) Update count method to support nuget service (maint) Update Chocolatey.NuGet.Client version (build) Update GRM Template to add full stop. (build) Update GRM config for BuildAutomation tag (#508) Ensure correct configuration object is used (tests) Use nuspec for version normalization tests (tests) Tag version normalization Pester tests (#158) Restore --source in tab completion for list (#158) Refactoring based on pairing session (#158) Restore --source for choco list (maint) Add vscode settings file (maint) Changes during pairing session (tests) Add non-normalized version Pester tests (maint) Update testing vagrant for granular runs ...
Strike that - my apologies. Looks like |
If you are using If you are a user at the desktop running See the upgrade guide. Note that the discussion to add the exception for EDIT: Just noted you'd updated your comment. Glad it's working for you. Feel free to ignore parts of the above 😄 |
### Rationale for this change Because it's removed and needless now. https://docs.chocolatey.org/en-us/guides/upgrading-to-chocolatey-v2-v6#the-list-command-now-lists-local-packages-only-and-the-local-only-and-lo-options-have-been-removed > The List Command Now Lists Local Packages Only and the --local-only and -lo Options Have Been Removed > > In version 1.0.0 of Chocolatey CLI, we added notices that the choco list command will list only local packages, and deprecated the -l and it's alias options. See this [GitHub issue for more information](chocolatey/choco#158). We have also removed the -a and it's alias options from the list command as it no longer made sense to have that option once side-by-side installs were removed. ### What changes are included in this PR? Just removed "-l". ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: #35990 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
The current default behaviour of
choco list
(orclist
) is to list ALL of the packages available on chocolatey (currently 2596 in total). This is a little slow, and not really helpful as a default.Couldn't the default behavior be to display "local only" packages, displaying only packages that are installed locally, as when you do
choco list --localonly
?Then require switches to get data from the repositories, rather than the other way around?
Implementation Notes
When this work is undertaken, the deprecation notices that were add in this PR will need to be reviewed/removed:
#2626
The text was updated successfully, but these errors were encountered: