Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#158) Add all possible unsupported argument permutations #3081

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

corbob
Copy link
Member

@corbob corbob commented Mar 20, 2023

Description Of Changes

Add all of the possible permutations for the no longer supported list command arguments

Motivation and Context

When the list of unsupported arguments was created, we missed adding the single-dash variants to the list as well as the double-dash variants.

Testing

  1. Build Chocolatey CLI
  2. Run choco list -lo and choco list --lo ensure that warning is emitted both times.
  3. Run choco list -all and choco list --all ensure that warning is emitted both times.

Operating Systems Testing

  • Windows 10

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #158

When the list of unsupported arguments was created, we missed adding the
single-dash variants to the list as well as the double-dash variants.
@corbob corbob requested a review from vexx32 March 20, 2023 17:18
@vexx32 vexx32 changed the base branch from develop to release/2.0.0 March 20, 2023 17:22
Copy link
Member

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for fixing this up! 💖

@vexx32 vexx32 merged commit 7a49903 into chocolatey:release/2.0.0 Mar 20, 2023
@corbob corbob deleted the list-warning-updates branch March 20, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change behavior of choco list to be local only
2 participants