(#158) Relegate the -lo/-li warning to log-file-only #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some discussion internally we determined that for folks to have smooth migration paths a log-file-only warning makes the most sense.
vexx32
changed the title
corbob
approved these changes
May 24, 2023
corbob
approved these changes
May 24, 2023
gep13
reviewed
May 24, 2023
| @@ -101,15 +101,27 @@ Describe "choco list" -Tag Chocolatey, ListCommand { | |||
|
|
|||
| Context "Listing local packages with unsupported argument outputs warning" -ForEach @('-l', '-lo', '--lo', '--local', '--localonly', '--local-only', '--order-by-popularity', '-a', '--all', '--allversions', '--all-versions', '-li', '-il', '-lai', '-lia', '-ali', '-ail', '-ial', '-ila') { | |||
There was a problem hiding this comment.
Shouldn't the name of this test change?
There was a problem hiding this comment.
Hmmm, yeah, sure, why not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
-lo/-lietc to log file only.Motivation and Context
After some discussion internally we determined that for folks to have smooth migration paths a log-file-only warning makes the most sense.
Testing
choco list -lo-liinstead of-loOperating Systems Testing
Win11
Change Types Made
Change Checklist
Related Issue
Fixes #158