Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35990: [CI][C++][Windows] Don't use -l for "choco list" #35991

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

kou
Copy link
Member

@kou kou commented Jun 8, 2023

Rationale for this change

Because it's removed and needless now.

https://docs.chocolatey.org/en-us/guides/upgrading-to-chocolatey-v2-v6#the-list-command-now-lists-local-packages-only-and-the-local-only-and-lo-options-have-been-removed

The List Command Now Lists Local Packages Only and the --local-only and -lo Options Have Been Removed

In version 1.0.0 of Chocolatey CLI, we added notices that the choco list command will list only local packages, and deprecated the -l and it's alias options. See this GitHub issue for more information. We have also removed the -a and it's alias options from the list command as it no longer made sense to have that option once side-by-side installs were removed.

What changes are included in this PR?

Just removed "-l".

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou kou requested review from assignUser and raulcd as code owners June 8, 2023 08:56
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

⚠️ GitHub issue #35990 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jun 8, 2023
@pitrou pitrou merged commit e920bed into apache:main Jun 8, 2023
@pitrou
Copy link
Member

pitrou commented Jun 8, 2023

Thanks @kou !

@kou kou deleted the cpp-ci-windows-choco-list branch June 8, 2023 21:18
@ursabot
Copy link

ursabot commented Jun 9, 2023

Benchmark runs are scheduled for baseline = a2e1f66 and contender = e920bed. e920bed is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️1.36% ⬆️0.18%] test-mac-arm
[Finished ⬇️13.07% ⬆️7.52%] ursa-i9-9960x
[Finished ⬇️0.27% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] e920bed4 ec2-t3-xlarge-us-east-2
[Finished] e920bed4 test-mac-arm
[Finished] e920bed4 ursa-i9-9960x
[Finished] e920bed4 ursa-thinkcentre-m75q
[Finished] a2e1f664 ec2-t3-xlarge-us-east-2
[Finished] a2e1f664 test-mac-arm
[Finished] a2e1f664 ursa-i9-9960x
[Finished] a2e1f664 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Jun 9, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting committer review Awaiting committer review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI][C++][Windows] "choco list -l" isn't available with choco v2
3 participants