Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microarchitectural test for ICCM #124

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Conversation

mkurc-ant
Copy link
Collaborator

This PR adds a microarchitectural test for the ICCM module. The test is written using pyuvm framework.

// SPDX-License-Identifier: Apache-2.0

module el2_ifu_iccm_mem_wrapper
import el2_pkg::*;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[verible-verilog-format] reported by reviewdog 🐶

Suggested change
import el2_pkg::*;
import el2_pkg::*;

import el2_pkg::*;
#(
`include "el2_param.vh"
)(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[verible-verilog-format] reported by reviewdog 🐶

Suggested change
)(
) (

Comment on lines +38 to +54
// Pack iccm_ext_in_pkt
el2_ccm_ext_in_pkt_t [pt.ICCM_NUM_BANKS-1:0] iccm_ext_in_pkt;

for (genvar i=0; i<pt.ICCM_NUM_BANKS; i++) begin
assign iccm_ext_in_pkt[i].TEST1 = iccm_ext_in_pkt_TEST1;
assign iccm_ext_in_pkt[i].RME = iccm_ext_in_pkt_RME;
assign iccm_ext_in_pkt[i].RM = iccm_ext_in_pkt_RM;
assign iccm_ext_in_pkt[i].LS = iccm_ext_in_pkt_LS;
assign iccm_ext_in_pkt[i].DS = iccm_ext_in_pkt_DS;
assign iccm_ext_in_pkt[i].SD = iccm_ext_in_pkt_SD;
assign iccm_ext_in_pkt[i].TEST_RNM = iccm_ext_in_pkt_TEST_RNM;
assign iccm_ext_in_pkt[i].BC1 = iccm_ext_in_pkt_BC1;
assign iccm_ext_in_pkt[i].BC2 = iccm_ext_in_pkt_BC2;
end

// The ICCM module
el2_ifu_iccm_mem mem (.*);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[verible-verilog-format] reported by reviewdog 🐶

Suggested change
// Pack iccm_ext_in_pkt
el2_ccm_ext_in_pkt_t [pt.ICCM_NUM_BANKS-1:0] iccm_ext_in_pkt;
for (genvar i=0; i<pt.ICCM_NUM_BANKS; i++) begin
assign iccm_ext_in_pkt[i].TEST1 = iccm_ext_in_pkt_TEST1;
assign iccm_ext_in_pkt[i].RME = iccm_ext_in_pkt_RME;
assign iccm_ext_in_pkt[i].RM = iccm_ext_in_pkt_RM;
assign iccm_ext_in_pkt[i].LS = iccm_ext_in_pkt_LS;
assign iccm_ext_in_pkt[i].DS = iccm_ext_in_pkt_DS;
assign iccm_ext_in_pkt[i].SD = iccm_ext_in_pkt_SD;
assign iccm_ext_in_pkt[i].TEST_RNM = iccm_ext_in_pkt_TEST_RNM;
assign iccm_ext_in_pkt[i].BC1 = iccm_ext_in_pkt_BC1;
assign iccm_ext_in_pkt[i].BC2 = iccm_ext_in_pkt_BC2;
end
// The ICCM module
el2_ifu_iccm_mem mem (.*);
// Pack iccm_ext_in_pkt
el2_ccm_ext_in_pkt_t [pt.ICCM_NUM_BANKS-1:0] iccm_ext_in_pkt;
for (genvar i = 0; i < pt.ICCM_NUM_BANKS; i++) begin
assign iccm_ext_in_pkt[i].TEST1 = iccm_ext_in_pkt_TEST1;
assign iccm_ext_in_pkt[i].RME = iccm_ext_in_pkt_RME;
assign iccm_ext_in_pkt[i].RM = iccm_ext_in_pkt_RM;
assign iccm_ext_in_pkt[i].LS = iccm_ext_in_pkt_LS;
assign iccm_ext_in_pkt[i].DS = iccm_ext_in_pkt_DS;
assign iccm_ext_in_pkt[i].SD = iccm_ext_in_pkt_SD;
assign iccm_ext_in_pkt[i].TEST_RNM = iccm_ext_in_pkt_TEST_RNM;
assign iccm_ext_in_pkt[i].BC1 = iccm_ext_in_pkt_BC1;
assign iccm_ext_in_pkt[i].BC2 = iccm_ext_in_pkt_BC2;
end
// The ICCM module
el2_ifu_iccm_mem mem (.*);

@github-actions
Copy link

Links to coverage and verification reports for this PR (#124) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

Internal-tag: [#49748]
Signed-off-by: Maciej Kurc <[email protected]>
Internal-tag: [#49748]
Signed-off-by: Maciej Kurc <[email protected]>
Internal-tag: [#49748]
Signed-off-by: Maciej Kurc <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Links to coverage and verification reports for this PR (#124) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@tmichalak
Copy link
Collaborator

LGTM

@tmichalak tmichalak merged commit 16dabe1 into chipsalliance:main Oct 4, 2023
40 checks passed
@mczyz-antmicro mczyz-antmicro deleted the iccm_test branch October 9, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants