-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add config struct and use slog #354
Conversation
aff7ff9
to
d2acc48
Compare
While testing the logs, I see some
This when sending an input:
|
@endersonmaia they are added automatically because they are already inside another string. |
Yeah, they're useless and are extra bytes in the log stream. Is it hard to avoid/remove them? And what about the second example?
Looks like terminal coloring from the inner rust service logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh boy, this is looking neat! I loved how text/template
made things so much easier to understand. I've only left a request concerning the logs and other small things.
2dce9ed
to
69ef09f
Compare
69ef09f
to
354ef5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
- Move node to internal package - Add a struct that contains all node config - Add structured logging with slog - Add CARTESI_LOG_PRETTY - Remove CARTESI_LOG_TIMESTAMP - Log Rust service's messages in the correct level - Print cartesi-rollups-cli to stdout Co-Author: Victor Yves Crispim <[email protected]> Co-Author: Francisco Moura <[email protected]>
354ef5b
to
52252aa
Compare
Co-Author: Victor Yves Crispim [email protected]
Co-Author: Francisco Moura [email protected]