Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate machine hash #357

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Validate machine hash #357

merged 4 commits into from
Mar 22, 2024

Conversation

torives
Copy link
Contributor

@torives torives commented Mar 19, 2024

Closes #259.

@torives torives added the #feat:go-supervisor Feature: Go supervisor label Mar 19, 2024
@torives torives requested review from fmoura and gligneul March 19, 2024 18:54
@torives torives self-assigned this Mar 19, 2024
@torives
Copy link
Contributor Author

torives commented Mar 19, 2024

The code can be reviewed, but this PR will be rebased on top of the main branch after #354 is merged.

torives added 3 commits March 21, 2024 10:27
@torives
refactor(deps): split container config
6f77ba1
@torives
refactor(deps): remove unused parameter
688e938
@torives
feat(deps): allow containers to run individually
3a5d76a 
It is now possible to execute a single container instead of always executing all containers defined within DepsConfig
@torives torives force-pushed the feat/validate-machine-hash branch 3 times, most recently from f8c1ffd to 060dbde Compare March 21, 2024 14:51
@torives torives marked this pull request as ready for review March 21, 2024 14:51
@torives torives force-pushed the feat/validate-machine-hash branch from 060dbde to 711097e Compare March 21, 2024 17:39
@torives
Copy link
Contributor Author

torives commented Mar 21, 2024 •
edited
Loading

This is now ready for review.

gligneul
gligneul suggested changes Mar 22, 2024
View reviewed changes
build/compose-host.yaml Outdated Show resolved Hide resolved
internal/node/machinehash_test.go Outdated Show resolved Hide resolved
internal/node/machinehash_test.go Outdated Show resolved Hide resolved
internal/node/machinehash_test.go Outdated Show resolved Hide resolved
internal/node/machinehash_test.go Outdated Show resolved Hide resolved
internal/node/machinehash_test.go Outdated Show resolved Hide resolved
@torives torives force-pushed the feat/validate-machine-hash branch 2 times, most recently from 6f4509e to 2034e30 Compare March 22, 2024 18:08
gligneul
gligneul previously approved these changes Mar 22, 2024
View reviewed changes
@torives torives force-pushed the feat/validate-machine-hash branch from 2034e30 to bd42c43 Compare March 22, 2024 18:22
@torives torives force-pushed the feat/validate-machine-hash branch 2 times, most recently from 0767715 to c2b0291 Compare March 22, 2024 19:07
@torives torives force-pushed the feat/validate-machine-hash branch from c2b0291 to 60c4ea6 Compare March 22, 2024 19:13
@torives torives merged commit 9534124 into main Mar 22, 2024
6 checks passed
@torives torives deleted the feat/validate-machine-hash branch March 22, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gligneul gligneul gligneul approved these changes

@fmoura fmoura Awaiting requested review from fmoura

Assignees

@torives torives

Labels
#feat:go-supervisor Feature: Go supervisor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check machine hash in Go
2 participants
@torives @gligneul