Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor config package #325

Closed
torives opened this issue Feb 20, 2024 · 0 comments · Fixed by #354
Closed

Refactor config package #325

torives opened this issue Feb 20, 2024 · 0 comments · Fixed by #354
Assignees
Labels
#feat:go-supervisor Feature: Go supervisor
Milestone

Comments

@torives
Copy link
Contributor

torives commented Feb 20, 2024

📚 Context

While writing our end-to-end tests, it became clear that the current config package wasn't appropriate for the new context, as it is highly cumbersome and error-prone setting/unsetting environment variables for individual tests.

Although #309 made strides in improving the situation by creating a NodeConfig struct, it soon became clear that the whole package would have to be adapted to this new way of handling the node's configuration.

@torives torives added the #feat:go-supervisor Feature: Go supervisor label Feb 20, 2024
@torives torives added this to the 1.4.0 milestone Feb 20, 2024
@marcelstanley marcelstanley moved this to 📋 Backlog in Node Unit Feb 20, 2024
@fmoura fmoura self-assigned this Feb 20, 2024
@fmoura fmoura added the epic A issue with several steps label Feb 20, 2024
@fmoura fmoura moved this from 📋 Backlog to 🏗 In progress in Node Unit Feb 26, 2024
@fmoura fmoura moved this from 🏗 In progress to 📋 Backlog in Node Unit Feb 28, 2024
@gligneul gligneul assigned gligneul and unassigned fmoura Mar 7, 2024
@gligneul gligneul moved this from 📋 Backlog to 🏗 In progress in Node Unit Mar 7, 2024
@gligneul gligneul removed the epic A issue with several steps label Mar 11, 2024
@gligneul gligneul linked a pull request Mar 14, 2024 that will close this issue
@gligneul gligneul moved this from 🏗 In progress to 👀 In review in Node Unit Mar 14, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Node Unit Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#feat:go-supervisor Feature: Go supervisor
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants