Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/release and promote cou #21

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Feat/release and promote cou #21

merged 2 commits into from
Jun 4, 2024

Conversation

jneo8
Copy link
Contributor

@jneo8 jneo8 commented May 31, 2024 •
edited
Loading

Follow #19

@jneo8 jneo8 requested a review from a team as a code owner May 31, 2024 06:59
@rgildein
Copy link
Contributor

We need to install the app first.

@jneo8 jneo8 force-pushed the feat/release-and-promote-cou branch from c13348f to 8a1e71a Compare May 31, 2024 07:10
@jneo8
Copy link
Contributor Author

jneo8 commented May 31, 2024

We need to install the app first.

It's installed.

@jneo8 jneo8 force-pushed the feat/release-and-promote-cou branch from 8a1e71a to 5619e53 Compare May 31, 2024 07:37
@jneo8 jneo8 mentioned this pull request May 31, 2024
Merged
Pjack
Pjack previously approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@Pjack Pjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to me to apply to cou

@chanchiwai-ray
Copy link
Contributor

can you run terraform fmt -recursive to fix the format?

@rgildein
Copy link
Contributor

rgildein commented Jun 3, 2024

can you run terraform fmt -recursive to fix the format?

Maybe we can this as ci step to verify it. terraform fmt -recursive -check

@jneo8
feat(terraform): Update cou's release workflow file with terraform te…
574804f 
…mplatefile

- Apply workflow files to chamred-openstack-upgrader
- Fix empty repository description in repo's settings
@jneo8 jneo8 force-pushed the feat/release-and-promote-cou branch from fe39d72 to 574804f Compare June 4, 2024 03:58
samuelallan72
samuelallan72 previously approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I had some suggestions, mostly about wording and descriptions, but they're nonblocking. Feel free to resolve and merge to test this out. We can follow up later with any minor improvements.

.github/workflows/terraform-apply.yaml Show resolved Hide resolved
terraform-plans/variables.tf Outdated Show resolved Hide resolved
terraform-plans/modules/GitHub/settings/variables.tf Show resolved Hide resolved
terraform-plans/files/github/snap_release.yaml Outdated Show resolved Hide resolved
chanchiwai-ray
chanchiwai-ray previously approved these changes Jun 4, 2024
View reviewed changes
.github/workflows/terraform-apply.yaml Outdated Show resolved Hide resolved
terraform-plans/configs/charmed-openstack-upgrader_3.x.tfvars Outdated Show resolved Hide resolved
@jneo8 jneo8 dismissed stale reviews from chanchiwai-ray and samuelallan72 via aa2ab7d June 4, 2024 09:05
@jneo8 jneo8 requested review from chanchiwai-ray and Pjack June 4, 2024 09:07
@jneo8
Copy link
Contributor Author

jneo8 commented Jun 4, 2024 •
edited
Loading

Please notice that once it merged, it may fire a PR and change the repository's settings for charmed-openstack-upgrader project.

@jneo8 jneo8 merged commit eb8fa8c into main Jun 4, 2024
1 check passed
@chanchiwai-ray chanchiwai-ray deleted the feat/release-and-promote-cou branch June 4, 2024 10:10
@Pjack
Copy link
Contributor

Pjack commented Jun 4, 2024

The setting are working on the repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanchiwai-ray chanchiwai-ray chanchiwai-ray approved these changes

@Pjack Pjack Pjack approved these changes

@samuelallan72 samuelallan72 samuelallan72 left review comments

@aieri aieri Awaiting requested review from aieri aieri is a code owner automatically assigned from canonical/soleng-reviewers

@gabrielcocenza gabrielcocenza Awaiting requested review from gabrielcocenza gabrielcocenza is a code owner automatically assigned from canonical/soleng-reviewers

@rgildein rgildein Awaiting requested review from rgildein rgildein is a code owner automatically assigned from canonical/soleng-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jneo8 @rgildein @chanchiwai-ray @Pjack @samuelallan72