Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/release and promote hw observer #22

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Feat/release and promote hw observer #22

merged 1 commit into from
Jun 5, 2024

Conversation

jneo8
Copy link
Contributor

@jneo8 jneo8 commented May 31, 2024

Follow: #19 and #21

@jneo8 jneo8 requested a review from a team as a code owner May 31, 2024 08:49
Pjack
Pjack previously approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@Pjack Pjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to me to apply to hardware observer.

@chanchiwai-ray
Copy link
Contributor

chanchiwai-ray commented Jun 3, 2024 •
edited
Loading

https://github.com/canonical/solutions-engineering-automation/actions/runs/9315533909/job/25641883492?pr=22#step:6:89 this does not look good. (p.s. link is not working, I am referring "Terraform plan" step, line 85. The description of the repository is removed)

@jneo8
Copy link
Contributor Author

jneo8 commented Jun 3, 2024

https://github.com/canonical/solutions-engineering-automation/actions/runs/9315533909/job/25641883492?pr=22#step:6:89 this does not look good. (p.s. link is not working, I am referring "Terraform plan" step, line 85. The description of the repository is removed)

https://github.com/canonical/solutions-engineering-automation/actions/runs/9315533909/job/25641883492?pr=22#step:6:89 this does not look good. (p.s. link is not working, I am referring "Terraform plan" step, line 85. The description of the repository is removed)

Nice catch, let me fix it.

chanchiwai-ray
chanchiwai-ray previously approved these changes Jun 5, 2024
View reviewed changes
@jneo8
feat(terraform): Update hw-observer's release.yaml and promote.yaml w…
b96f660 
…ith terraform

- Also fix error that use file instead of templatefile to compare the
file content
@jneo8 jneo8 dismissed stale reviews from chanchiwai-ray and Pjack via b96f660 June 5, 2024 06:29
@jneo8 jneo8 force-pushed the feat/release-and-promote-hw-observer branch from 83aef57 to b96f660 Compare June 5, 2024 06:29
@jneo8 jneo8 merged commit 5852e5e into main Jun 5, 2024
2 checks passed
@chanchiwai-ray chanchiwai-ray deleted the feat/release-and-promote-hw-observer branch June 5, 2024 06:45
@samuelallan72 samuelallan72 mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanchiwai-ray chanchiwai-ray chanchiwai-ray approved these changes

@samuelallan72 samuelallan72 samuelallan72 approved these changes

@Pjack Pjack Pjack approved these changes

@aieri aieri Awaiting requested review from aieri aieri is a code owner automatically assigned from canonical/soleng-reviewers

@gabrielcocenza gabrielcocenza Awaiting requested review from gabrielcocenza gabrielcocenza is a code owner automatically assigned from canonical/soleng-reviewers

@rgildein rgildein Awaiting requested review from rgildein rgildein is a code owner automatically assigned from canonical/soleng-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jneo8 @chanchiwai-ray @Pjack @samuelallan72