Skip to content

Commit

Permalink
fix: Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jneo8 committed Jun 4, 2024
1 parent 574804f commit aa2ab7d
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 27 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/terraform-apply.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@ jobs:
fail-fast: false
matrix:
repository:
# The naming of the files should be $REPO_$BRANCH.tfvars
- charmed-openstack-upgrader_main
# The snapcraft channel for 3.x is not ready
# - charmed-openstack-upgrader_3.x
steps:
- name: Checkout branch
uses: actions/checkout@v4
Expand Down
22 changes: 0 additions & 22 deletions terraform-plans/configs/charmed-openstack-upgrader_3.x.tfvars

This file was deleted.

2 changes: 1 addition & 1 deletion terraform-plans/files/github/snap_release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0 # NOTE(rgildein): Fetch all tags as the latest tag is required for build.
fetch-depth: 0 # Complete git history is required to generate the version from git tags.
- uses: snapcore/action-build@v1
id: build
- uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion terraform-plans/modules/GitHub/workflows/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ variable "workflow_files" {
destination = string
variables = map(string)
}))
description = "GitHub workflow files"
description = "GitHub workflow file. The source is the file path of the template file."
}
2 changes: 1 addition & 1 deletion terraform-plans/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ variable "workflow_files" {
destination = string
variables = map(string)
}))
description = "GitHub workflow files"
description = "GitHub workflow file. The source is the file path of the template file."
}

0 comments on commit aa2ab7d

Please sign in to comment.