Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add charmcraft part to prime files #496

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

carlcsaposs-canonical
Copy link
Contributor

Support for prime in charm part removed in charmcraft 3

Support for `prime` in `charm` part removed in charmcraft 3
@carlcsaposs-canonical carlcsaposs-canonical marked this pull request as ready for review August 2, 2024 09:44
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be deprecated only and should still work... but LGTM to be the future compatible.

carlcsaposs-canonical added a commit to canonical/opensearch-operator that referenced this pull request Aug 14, 2024
I'd like to standardize the approach across data platform repos so that future automated tooling that may need to use this can be shared across all our repos

PRs in other repos:
canonical/mysql-operator#496
canonical/mysql-router-k8s-operator#298 (comment)
canonical/mongodb-operator#455
Mehdi-Bendriss pushed a commit to canonical/opensearch-operator that referenced this pull request Aug 15, 2024
I'd like to standardize the approach across data platform repos so that
future automated tooling that may need to use this can be shared across
all our repos

PRs in other repos:
canonical/mysql-operator#496

canonical/mysql-router-k8s-operator#298 (comment)
canonical/mongodb-operator#455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants