Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-4976] Add workflow for nightly scheduled tests with juju 3.6 #502

Merged
merged 17 commits into from
Aug 29, 2024

Conversation

shayancanonical
Copy link
Contributor

@shayancanonical shayancanonical commented Aug 6, 2024

Issue

We would like to run nightly tests with juju 3.6

Solution

Upgrade to dpw v21.0.0 and add juju 3.6 into the matrix for tests. Also, upgrade libjuju to ^3.5.2.0

@shayancanonical
Copy link
Contributor Author

All juju 3.6 tests pass in https://github.com/canonical/mysql-operator/actions/runs/10460916031/ which is the run for commit hash 4c7ba8e

@shayancanonical
Copy link
Contributor Author

Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as I mentioned earlier (and asked you to sync with me about for dpw changes), I think we should add 3.6 to the matrix in ci.yaml and set it to only run nightly on dpw

Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Nice!
I surprised to see base working on Juju 2.9. Nice!
Can you please update pinning to LXD/Microk8s (can be followup PR if you want).

cloud: lxd
juju-snap-channel: 3.6/beta
libjuju-version-constraint: 3.5.2.0
lxd-snap-channel: 5.21/stable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, we should use here LXD latest/stable: v.6.1.
Reasons: Field will deploy Juju LTS with latest stable LXD.

Also, please pin MicroK8s here with renovate refresh label as discussed in MM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add a renovate refresh label for lxd in a separate PR once a preset for lxd has been created.

do we want to use latest/stable: v6.1 for all juju versions?

@carlcsaposs-canonical
Copy link
Contributor

@taurus-forever do you want 3.6 on amd64 only, arm64 only, or both?

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
libjuju-version-constraint: ${{ matrix.juju.libjuju }}
lxd-snap-channel: 5.21/stable
lxd-snap-channel: ${{ matrix.lxd_channel || '5.21/stable' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use same lxd channel for all runs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running all tests with lxd 6.1/stable in 0f57e9a. please confirm that this is alright @taurus-forever

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
charmcraft.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
@shayancanonical shayancanonical merged commit a33f413 into main Aug 29, 2024
99 checks passed
@shayancanonical shayancanonical deleted the feature/juju_3_6_tests branch August 29, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants