-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-4976] Add workflow for nightly scheduled tests with juju 3.6 #502
Conversation
…ith consistent approach
All juju 3.6 tests pass in https://github.com/canonical/mysql-operator/actions/runs/10460916031/ which is the run for commit hash 4c7ba8e |
All juju 2.9.49 and 3.4.4 tests pass in https://github.com/canonical/mysql-operator/actions/runs/10472342308 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as I mentioned earlier (and asked you to sync with me about for dpw changes), I think we should add 3.6 to the matrix in ci.yaml and set it to only run nightly on dpw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Nice!
I surprised to see base
working on Juju 2.9. Nice!
Can you please update pinning to LXD/Microk8s (can be followup PR if you want).
.github/workflows/juju_3_6_ci.yaml
Outdated
cloud: lxd | ||
juju-snap-channel: 3.6/beta | ||
libjuju-version-constraint: 3.5.2.0 | ||
lxd-snap-channel: 5.21/stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, we should use here LXD latest/stable: v.6.1.
Reasons: Field will deploy Juju LTS with latest stable LXD.
Also, please pin MicroK8s here with renovate refresh label as discussed in MM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will add a renovate refresh label for lxd in a separate PR once a preset for lxd has been created.
do we want to use latest/stable: v6.1
for all juju versions?
@taurus-forever do you want 3.6 on amd64 only, arm64 only, or both? |
.github/workflows/ci.yaml
Outdated
libjuju-version-constraint: ${{ matrix.juju.libjuju }} | ||
lxd-snap-channel: 5.21/stable | ||
lxd-snap-channel: ${{ matrix.lxd_channel || '5.21/stable' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use same lxd channel for all runs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
running all tests with lxd 6.1/stable in 0f57e9a. please confirm that this is alright @taurus-forever
Issue
We would like to run nightly tests with juju 3.6
Solution
Upgrade to dpw v21.0.0 and add juju 3.6 into the matrix for tests. Also, upgrade libjuju to
^3.5.2.0