-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Charmcraft 3.1.1 removed support for parts
- when documentation clearly states it is deprecated
#1782
Comments
Yeh, we definitely still need to support |
fyi, it's still possible to prime files with something like canonical/mysql-operator#496 but the use of "deprecated" is confusing, since it's been removed instead of deprecated |
This fixes the charm packing incorrectly due to a behaviour change in charmcraft 3. See: canonical/charmcraft#1782
@MiaAltieri @carlcsaposs-canonical please this updated documentation and let me know if it needs further clarification: |
## Issue In Charmcraft 3, the behaviour of the `prime` keyword has changed, and the warning and documentation are not clear about the change. See: canonical/charmcraft#1782 ## Solution Use the `dump` plugin to include extra files, priming only the files needed. --------- Co-authored-by: Mehdi Bendriss <[email protected]>
I haven't heard back so I presume these doc changes are okay. The code changes are included in the 3.1.2 hotfix, but please let me know if the doc changes are still confusing. |
Bug Description
Hi Charmcraft Team ⭐️
I am sure that someone has already notified you. But the recent release of charmcraft
3.1.1
has started breaking CI which usessnap
in theparts
file of VM Charms.Granted :
Warning: use of 'prime' in a charm part is deprecated and no longer works, see https://juju.is/docs/sdk/include-extra-files-in-a-charm
So I understand that
prime
is to eventually go away. But I would expect it to be still usable since the docs say:The key here being Users can still use this method to filter existing files.
So my question here, is Charmcraft broken or are the docs incorrect. Thank you
To Reproduce
charmcraft pack any charm that uses a parts section
Environment
Ubuntu - 22.04
Charmcraft - 3.1.1
LXD - 5.0.3-80aeff7
charmcraft.yaml
Relevant log output
The text was updated successfully, but these errors were encountered: