Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_detected_object_validation): set validate distance in the obstacle pointcloud based validator #9663

Merged
merged 3 commits into from
Dec 17, 2024

chore: add validate_max_distance_m parameter for obstacle_pointcloud_…

f63d6a3
Select commit
Loading
Failed to load commit list.
Merged

feat(autoware_detected_object_validation): set validate distance in the obstacle pointcloud based validator #9663

chore: add validate_max_distance_m parameter for obstacle_pointcloud_…
f63d6a3
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Dec 16, 2024 in 41s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.29 (9.39 -> 9.10)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method obstacle_pointcloud_validator.cpp: ObstaclePointCloudBasedValidator::onObjectsAndObstaclePointCloud

Annotations

Check warning on line 362 in perception/autoware_detected_object_validation/src/obstacle_pointcloud/obstacle_pointcloud_validator.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method 

ObstaclePointCloudBasedValidator::onObjectsAndObstaclePointCloud has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis