-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_detected_object_validation): set validate distance in the obstacle pointcloud based validator #9663
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
…based_validator Signed-off-by: Taekjin LEE <[email protected]>
…idator Signed-off-by: Taekjin LEE <[email protected]>
a3845ab
to
3ee025a
Compare
…based_validator Signed-off-by: Taekjin LEE <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9663 +/- ##
=======================================
Coverage 29.80% 29.81%
=======================================
Files 1443 1443
Lines 108592 108581 -11
Branches 42664 42645 -19
=======================================
Hits 32369 32369
+ Misses 73044 73033 -11
Partials 3179 3179
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- I did NOT check this PR by running autoware.
Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-9663/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…he obstacle pointcloud based validator (autowarefoundation#9663) * chore: add validate_max_distance_m parameter for obstacle_pointcloud_based_validator Signed-off-by: Taekjin LEE <[email protected]> * chore: optimize object distance validation in obstacle_pointcloud_validator Signed-off-by: Taekjin LEE <[email protected]> * chore: add validate_max_distance_m parameter for obstacle_pointcloud_based_validator Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
…he obstacle pointcloud based validator (autowarefoundation#9663) * chore: add validate_max_distance_m parameter for obstacle_pointcloud_based_validator Signed-off-by: Taekjin LEE <[email protected]> * chore: optimize object distance validation in obstacle_pointcloud_validator Signed-off-by: Taekjin LEE <[email protected]> * chore: add validate_max_distance_m parameter for obstacle_pointcloud_based_validator Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
Description
A set of detected objects is validated by the obstacle pointcloud, which is the result of a rule-based detection
ground segmentation
.In far ranges, however, it is difficult to separate non-ground obstacle since reflection of ground in far range is very week or absent due to the shallow angle.
A parameter
validate_max_distance_m
is added to not validate object far than this parameter.Related links
Launcher PR autowarefoundation/autoware_launch#1277
How was this PR tested?
TIER IV INTERNAL
Experiment condition
ground segmentation setting : change parameters to make obstacle pointcloud less in far distance (for test purpose)
obstacle pointcloud based validator set a short validation distance (for test purpose)
Before
Blue bounding box: detected objects
Yellow bounding box: validated objects
White points: obstacle pointcloud
Since the obstacle pointclouds are fail to segment obstacles in far ranges, far objects are filtered out.
After
Blue bounding box: detected objects
Yellow bounding box: validated objects
Even the obstacle pointclouds are absent, objects far than 40m could pass the validator.
Notes for reviewers
The parameter
validate_max_distance_m
need to be set where the ground segmentation is less accurate. If this parameter is set too close, there is a risk that the detected is object is not validated.Interface changes
None.
Effects on system behavior
None.