Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map loader): visualize bus stop area and bicycle_lane #8777

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Sep 5, 2024

Description

depends #8800

visualize bus stop area and bicycle_lane

bicycle_lane

image

bus_stop_area

image

Related links

depends autowarefoundation/autoware_lanelet2_extension#28
autowarefoundation/autoware_lanelet2_extension#29

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin force-pushed the feat/map-loader/visualize-bus-stop-area branch from 76c57b8 to 6938115 Compare September 5, 2024 15:29
@soblin soblin marked this pull request as ready for review September 5, 2024 15:30
@soblin soblin changed the title feat(map loader): visualize bus stop area and bicycle_lane DO NOT MERGE feat(map loader): visualize bus stop area and bicycle_lane Sep 5, 2024
@soblin soblin changed the title DO NOT MERGE feat(map loader): visualize bus stop area and bicycle_lane feat(map loader): visualize bus stop area and bicycle_lane Sep 6, 2024
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 6, 2024
Signed-off-by: Mamoru Sobue <[email protected]>
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 24.88%. Comparing base (301e36b) to head (58fda64).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...et2_map_loader/lanelet2_map_visualization_node.cpp 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8777      +/-   ##
==========================================
- Coverage   25.02%   24.88%   -0.14%     
==========================================
  Files        1322     1331       +9     
  Lines       98047    98336     +289     
  Branches    37795    37795              
==========================================
- Hits        24536    24471      -65     
- Misses      71020    71386     +366     
+ Partials     2491     2479      -12     
Flag Coverage Δ *Carryforward flag
differential 9.71% <0.00%> (?)
total 25.00% <ø> (-0.03%) ⬇️ Carriedforward from 8213bdf

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin merged commit 225e18b into autowarefoundation:main Sep 9, 2024
30 of 32 checks passed
@soblin soblin deleted the feat/map-loader/visualize-bus-stop-area branch September 9, 2024 03:30
emuemuJP pushed a commit to arayabrain/autoware.universe.origin that referenced this pull request Sep 10, 2024
@vividf
Copy link
Contributor

vividf commented Oct 10, 2024

Just in case someone failed to build autoware because of map_loader package
Run sudo apt remove ros-humble-autoware-lanelet2-extension ros-humble-autoware-lanelet2-extension-python and rebuild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants