Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map loader): visualize bus stop area and bicycle_lane #8777

Merged
merged 4 commits into from
Sep 9, 2024

add maitainer

58fda64
Select commit
Loading
Failed to load commit list.
Merged

feat(map loader): visualize bus stop area and bicycle_lane #8777

add maitainer
58fda64
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Sep 6, 2024 in 39s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.12 (8.85 -> 8.74)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method lanelet2_map_visualization_node.cpp: Lanelet2MapVisualizationNode::on_map_bin

Annotations

Check warning on line 314 in map/map_loader/src/lanelet2_map_loader/lanelet2_map_visualization_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method 

Lanelet2MapVisualizationNode::on_map_bin increases from 195 to 219 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis