Bring back dataset as a required field for BigQuery profile
#1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR #1017, we attempted to remove `dataset` from the required fields list for the BigQuery profile. However, we realised that this is failing BiqQuery dbt operations as it indeed is a required field. Hence, bring back the same as a required field. This is also necessary for building the mock profile where we construct the profile by taking in consideration only the required fields. closes: #1031
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1033 +/- ##
=======================================
Coverage 95.77% 95.77%
=======================================
Files 62 62
Lines 2979 2979
=======================================
Hits 2853 2853
Misses 126 126 ☔ View full report in Codecov by Sentry. |
dosubot
bot
added
size:XS
tatiana
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
@pankajkoti this looks great, thanks a lot for the very fast fix!
pankajkoti
added a commit
that referenced
this pull request
Jun 7, 2024
In PR #1017, we attempted to remove `dataset` from the required fields list for the BigQuery profile. However, we realised that this is failing BiqQuery dbt operations as it indeed is a required field. Hence, bring back the same as a required field. This is also necessary for building the mock profile where we construct the profile by taking in consideration only the required fields. Closes: #1031 (cherry picked from commit 803776a)
Merged
pankajkoti
added a commit
that referenced
this pull request
Jun 7, 2024
Bug fixes * Bring back ``dataset`` as a required field for BigQuery profile by @pankajkoti in #1033 Enhancements * Only run ``dbt deps`` when there are dependencies by @tatiana in #1030 Docs * Fix docs so it does not reference non-existing ``get_dbt_dataset`` by @tatiana in #1034 --------- Co-authored-by: Tatiana Al-Chueyr <[email protected]>
arojasb3
pushed a commit
to arojasb3/astronomer-cosmos
that referenced
this pull request
Jul 14, 2024
…omer#1033) In PR astronomer#1017, we attempted to remove `dataset` from the required fields list for the BigQuery profile. However, we realised that this is failing BiqQuery dbt operations as it indeed is a required field. Hence, bring back the same as a required field. This is also necessary for building the mock profile where we construct the profile by taking in consideration only the required fields. Closes: astronomer#1031
arojasb3
pushed a commit
to arojasb3/astronomer-cosmos
that referenced
this pull request
Jul 14, 2024
Bug fixes * Bring back ``dataset`` as a required field for BigQuery profile by @pankajkoti in astronomer#1033 Enhancements * Only run ``dbt deps`` when there are dependencies by @tatiana in astronomer#1030 Docs * Fix docs so it does not reference non-existing ``get_dbt_dataset`` by @tatiana in astronomer#1034 --------- Co-authored-by: Tatiana Al-Chueyr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #1017, we attempted to remove
datasetfrom the required fields list for the BigQuery profile. However, we realised that this is failing BiqQuery dbt operations as it indeed is a required field. Hence, bring back the same as a required field. This is also necessary for building the mock profile where we construct the profile by taking in consideration only the required fields.closes: #1031