Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back dataset as a required field for BigQuery profile #1033

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Bring back dataset as a required field for BigQuery profile #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cosmos/profiles/bigquery/service_account_keyfile_dict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,11 @@ class GoogleCloudServiceAccountDictProfileMapping(BaseProfileMapping):
dbt_profile_type: str = "bigquery"
dbt_profile_method: str = "service-account-json"

# Do not remove dataset as a required field form the below list. Although it's observed that it's not a required
# field for some databases like Postgres, it's required for BigQuery.
required_fields = [
"project",
"dataset",
"keyfile_json",
]

Expand Down
1 change: 1 addition & 0 deletions tests/profiles/bigquery/test_bq_service_account_keyfile_dict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ def test_mock_profile(mock_bigquery_conn_with_dict: Connection):
"type": "bigquery",
"method": "service-account-json",
"project": "mock_value",
"dataset": "mock_value",
"threads": 1,
"keyfile_json": None,
}
Expand Down
Loading