Release 1.4.3 #1035
Merged
Release 1.4.3 #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Cosmos 1.4, Cosmos will attempt to run dbt deps even if there are no `dependencies.yml` or `packages.yml` in the dbt project directory. This causes an unnecessary overhead in creating subprocesses without any benefit. This problem was initially spotted by @AlgirdasDubickas, who created a pull request proposing a solution to the problem: #893 Despite the original PR becoming stale, the problem it addresses remains relevant. This PR proposes a different implementation to solve the same problem. It addresses the issue from a rendering perspective (converting a dbt project into an Airflow DAG using `LoadMode.DBT_LS`) and an execution perspective (when Airflow worker nodes run/trigger dbt commands to be run when using `ExecutionMode.LOCAL` or `ExecutionMode.VIRTUALENV`). Co-authored-by: AlgirdasDubickas <[email protected]> (cherry picked from commit 3a63bee)
In PR #1017, we attempted to remove `dataset` from the required fields list for the BigQuery profile. However, we realised that this is failing BiqQuery dbt operations as it indeed is a required field. Hence, bring back the same as a required field. This is also necessary for building the mock profile where we construct the profile by taking in consideration only the required fields. Closes: #1031 (cherry picked from commit 803776a)
[The documentation](https://astronomer.github.io/astronomer-cosmos/configuration/scheduling.html) was outdated. The method `get_dbt_dataset` no longer exists. It used to exist in older versions of Cosmos (before 1.1) when the URIs respected the format: `Dataset(f"DBT://{connection_id.upper()}/{project_name.upper()}/{model_name.upper()}")` More information on why we changed this: #305 Closes: #1032 (cherry picked from commit c47e104)
dosubot
bot
added
the
size:L
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
tatiana
approved these changes
Jun 7, 2024
dosubot
bot
added
lgtm
arojasb3
pushed a commit
to arojasb3/astronomer-cosmos
that referenced
this pull request
Jul 14, 2024
Bug fixes * Bring back ``dataset`` as a required field for BigQuery profile by @pankajkoti in astronomer#1033 Enhancements * Only run ``dbt deps`` when there are dependencies by @tatiana in astronomer#1030 Docs * Fix docs so it does not reference non-existing ``get_dbt_dataset`` by @tatiana in astronomer#1034 --------- Co-authored-by: Tatiana Al-Chueyr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes
datasetas a required field for BigQuery profile by @pankajkoti in Bring backdatasetas a required field for BigQuery profile #1033Enhancements
dbt depswhen there are dependencies by @tatiana in Only rundbt depswhen there are dependencies #1030Docs
get_dbt_datasetby @tatiana in Fix docs so it does not reference non-existingget_dbt_dataset#1034